-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[useTranslation] Avoid setting the new t
function if the component is unmounted.
#1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 for the issue. |
Looks valid...never run into this myself - but thinking about it the case is valid. Will deeper check this when back from holidays (this weekend, early next week) and merge this into master. |
sorry forgot about this one...published in react-i18next@11.3.4 |
This was referenced Mar 20, 2020
This was referenced Mar 20, 2020
1 task
1 task
1 task
This was referenced Mar 22, 2020
Merged
This was referenced Aug 28, 2020
This was referenced Sep 23, 2020
Closed
This was referenced Dec 2, 2020
Closed
Closed
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the translations are loaded from backend, the hook sets its
t
function without checking that the component is still mounted, which induces an error fromreact-dom
.Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
I've updated the code to keep the
isMounted
pattern to be consistent with the previous version, but I'll gladly change it for a promise cancellation if you find it more appropriate.