Updated TS definitions #1247
Merged
Updated TS definitions #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18next#778 had forgotten the HOC
|
@pedrodurek can you have a look? |
pedrodurek
suggested changes
Feb 3, 2021
src/ts4.1/index.d.ts
Outdated
| @@ -228,5 +228,5 @@ export interface TranslationProps<N extends Namespace = DefaultNamespace> { | |||
| } | |||
|
|
|||
| export function Translation<N extends Namespace = DefaultNamespace>( | |||
| props: TranslationProps<N>, | |||
| props: TranslationProps<N> & { useSuspense?: boolean }, | |||
There was a problem hiding this comment.
Hey @depoulo, thanks for your contribution.
src/index.d.ts is right, but here we should place useSuspense under TranslationProps.
of course 🤦🏽
pedrodurek
approved these changes
Feb 8, 2021
|
thanks to all helping with this PR - published in react-i18next@11.8.6 |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#778 had forgotten the HOC
If you wish, I can also update:
Checklist
npm run test