Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generics from Trans component to suppress warning issue #1400

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Nov 9, 2021

Closes #1394

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 04eaeee on pedrodurek:fix-trans-component into 269021e on i18next:master.

@adrai adrai merged commit f3612c5 into i18next:master Nov 9, 2021
@adrai
Copy link
Member

adrai commented Nov 9, 2021

thank you @pedrodurek
released with v11.14.0

@mrlubos
Copy link

mrlubos commented Nov 10, 2021

Hi @pedrodurek @adrai. It appears this pull request removes the warning issue, but it introduces a whole new error instead. 😃 Are you able to tell me what I'm doing wrong please? You can see the issue at #1401

pedrodurek added a commit to pedrodurek/react-i18next that referenced this pull request Nov 10, 2021
adrai pushed a commit that referenced this pull request Nov 10, 2021
adrai added a commit that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants