Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Translation component types regression #1511

Merged
merged 1 commit into from
Jun 3, 2022
Merged

fix Translation component types regression #1511

merged 1 commit into from
Jun 3, 2022

Conversation

dermoumi
Copy link
Contributor

@dermoumi dermoumi commented Jun 3, 2022

Fixes the error that typescript started raising since last release 11.16.10:

Error: [...]react-i18next/ts4.1/index.d.ts(371,75): error TS2706: Required type parameters may not follow optional type parameters.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@adrai
Copy link
Member

adrai commented Jun 3, 2022

@vovsemenv can you review? //cc @pedrodurek

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.951% when pulling 9f2e0f0 on dermoumi:fix-prop-typing-regression into 985356c on i18next:master.

Copy link
Contributor

@vovsemenv vovsemenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! I missed it because i have skiplibCheck in my project tsconfig.

@adrai adrai merged commit b3e7d3d into i18next:master Jun 3, 2022
@adrai
Copy link
Member

adrai commented Jun 3, 2022

thank you v11.16.11 has just been released

@vovsemenv
Copy link
Contributor

Adriano, i don't know how OSS maintainer can be this fast. You the best)

@adrai
Copy link
Member

adrai commented Jun 3, 2022

Thank you for your nice words... not hearing this a lot... really appreciate that. 😊

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project.

There are many ways to help this project 🙏

@dermoumi
Copy link
Contributor Author

dermoumi commented Jun 3, 2022

Keep up the great work guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants