Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the type of defaultNS in I18nextProvider should support string[] #1633

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: the type of defaultNS in I18nextProvider should support string[] #1633

merged 1 commit into from
Apr 24, 2023

Conversation

Clarkkkk
Copy link
Contributor

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

Coverage: 95.741%. Remained the same when pulling ceabefa on Clarkkkk:master into 7026d54 on i18next:master.

@adrai adrai merged commit 807182d into i18next:master Apr 24, 2023
@adrai
Copy link
Member

adrai commented Apr 24, 2023

thank you, included in v12.2.1

@chncaption chncaption mentioned this pull request Sep 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clarkkkk @coveralls @adrai