-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to react v18 #1789
Conversation
Theoretically, if we keep the peerDependency of react as is, there is no need for a breaking release, since the v18 react is only needed because of the tests. |
@adrai If in the future we use a feature that isn't compatible with v16/17 we could that break compatibility without realising. However since the project is pretty stable (and so is react) I guess that's not very likely to happen. I'm happy to not bump the react version if that's your preference. Any thoughts on the test with the comment? Leave as is/simplify? I'll make the peerdep change now to unblock this PR from being merged but can simplify the tests in a separate PR if you think that's fine. |
ok, 👍 |
I see. In that case I'll leave the test as is. I have reverted the change to the react peer deps so the PR should be ready to merge. |
thank you 👍 |
Description:
Upgrades to react v18.
Checklist
npm run test