Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default lang bug when React tree doesn't contain withI18next #592

Merged
merged 2 commits into from
Oct 28, 2018
Merged

Fix default lang bug when React tree doesn't contain withI18next #592

merged 2 commits into from
Oct 28, 2018

Conversation

isaachinman
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.023% when pulling 0e451c4 on isaachinman:master into 19f5f3f on i18next:master.

@jamuhl jamuhl merged commit f9286f6 into i18next:master Oct 28, 2018
@jamuhl
Copy link
Member

jamuhl commented Oct 28, 2018

thank you for looking deeper into it...really appreciate your help.

personal i'm looking into the 16.7 release of react -> guess will bring some changes to next.js too

@isaachinman
Copy link
Contributor Author

Yup, it probably does. I haven't looked at 16.7 yet, but I might get a chance to this week. Just let me know if you need anything!

@jamuhl
Copy link
Member

jamuhl commented Oct 28, 2018

prepared a react-i18next version based on hooks and suspense (no support for SSR yet) -> if you ever into it you might have a look: #590

@isaachinman
Copy link
Contributor Author

Nice! I will take a look sometime this week.

@Enalmada
Copy link
Contributor

Enalmada commented Nov 3, 2018

@isaachinman When I run the latest nextjs example from master, clicking any link appears to do a full page change and flicker. I wanted to look at how you fixed the default lang bug and am worried the solution may being doing something to break routing?

@isaachinman
Copy link
Contributor Author

@Enalmada Yes, that is correct. The fix caused a regression, which is now also fixed. I plan on doing a complete rewrite of the example pretty soon. You can add your feedback in #609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants