This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Bugfix: StrokeWidth #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're setting up the `stroke` property, but Fabric wants us to use `strokeWidth` here instead.
This is the object property we need for Fabric to actually widen out marker strokes.
I'm not sure what this option/property is doing, but it's moving around objects and lines in the image in very strange ways. Dropping this property fixes positioning issues.
Fabric appears to rely on the `stroke` property for the color of objects, not this color property. Drop it.
|
Note, the slight rectangle shift, and lack of white shadow/border is highlighted well here: |
|
CR 🌵 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a Fabric.js interface mismatch on our latest version.
Specifically, it appears master is trying to pass
borderWidthto Fabric objects for their strokeWidth. This does not draw objects as expected. We see thatHere's a montage of the test images from master:
With these light fixes applied, we're actually drawing the shapes we expect, pretty close to our test oracle images:
qa_req 0 (another small step in the right direction here)
Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops