This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Bugfix: Fix strokeline props #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our render hasn't been including nice rounded edges. This adds the needed translation from Fabric to plain canvas ctx draw functions. We can also default these properties to ensure they're always reasonable for use.
In the previous commit, we've set default values for these stroke properties in our custom highlighted stroke. As we're now duplicating the default, these can go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
strokeLineCapandstrokeLineJoinproperties we are using for our custom stroke implementation do not match the Canvas API properties for the same.Ref: (Fabric): http://fabricjs.com/docs/fabric.Line.html#strokeLineCap
This seems to match the SVG name for that property:
Ref: (MDN SVGs): https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-linecap
But not the Canvas API for the same:
Ref: (MDN CanvasRC2D): https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineCap
This repairs the nice rounded edges (for lines, and the drop highlight) for our lines, caps, and rectangles.
Examples
Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops