This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Bugfix: put back borderWidth #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, i erroneously dropped the `borderWidth` property. 3ad42ee At the time, using this property was changing object positioning in difficult to explain ways. Presumably fixing our render functions in #73 has corrected the positioning bug. Bring back this property, effectively the strokeWidth, brings the line widths on our test images into much better parity with the oracle images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, i erroneously dropped the
borderWidthproperty. 3ad42eeAt the time, using this property was changing object positioning in difficult to explain ways. Presumably fixing our render functions in #73 has corrected the positioning bug. Bring back this property, effectively the strokeWidth, brings the line widths on our test images into much better parity with the oracle images.
qa_req 0
Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops