This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Export Fabric #77
Merged
Export Fabric #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to import Fabric on each init of the Builder.
We're using a custom build of Fabric.js internally, for both `node-markup`, and the main app/UI. To make dependency management easier, lets export our Fabric dependency from the builder. This lets us avoid manually managing the peer dependency between the two.
|
CR 👍 Good call. When we update to the latest fabric, do we still need to use a custom build? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using a custom build of Fabric.js internally. In order to facilitate dependency management, export our Fabric dependency from
Builder. This lets us avoid manually managing this peer dependency.We intend upstream to explicitly reuse this Fabric.js dependency:
https://github.com/iFixit/ifixit/blob/394eeb1c6164e88360827aa9bc3e6013f661e44d/carpenter-frontend/Shared/FrameModules/Image/image_markers_next.js#L258
Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops