This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Update oracle images #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd stubbed out the image tests passing to faciliate upgrades. Now that we're updating the oracle images to match the current state, lets resume enforcing passing the image tests during CI and build.
danielbeardsley
approved these changes
Sep 19, 2022
andyg0808
approved these changes
Sep 19, 2022
|
CR 🐶 through 27eb112 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated this library heavily, and we're very close to exact matches on our tests.
It appears the differences now are subtle enough for us to not worry. These appear to subtle jpeg encoding differences, and subtle anti-aliasing differences. These are most likely occurring because we are updating cairo underneath
node-canvas.Github is doing a great job showing the differences in the images! Hopefully that leaves us confident to call this QA.
Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops