This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Bump Fabric.js to include Animations module #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never want to be checking in the lock for this repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates a branch upstream on Fabric.js:
iFixit/fabric.js@try-v521...iFixit:fabric.js:try-v521-with-anim
animationmodule to our custom builddistIn the main app, we're seeing several different actions and codepaths that trigger internal Fabric usage of
farbic.util.requestAnimationFrame. Without this animation module, we see hard crashes of the in-browser editor. I think for the short term, it will be better to tolerate the extra Fabric module. Eventually we may work to remove the dependency onrequestAnimationFrame, but for now, "working at all" is better than nothing.Ref: https://github.com/iFixit/ifixit/issues/43782
CC @iFixit/devops