This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Hot Fix: Make Runners Explicitly use Node Version 16 #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default node version for the runners was changed to 18, which is not compatible with our current setup. Unfortunately, this change was not properly announced, which is why we did not notice it. There is only a GH issue about it at the moment. actions/runner-images#7002 In order to fix this, we need to explicitly set the node version to 16 for all our workflows that use node/pnpm.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mlahargou
approved these changes
Feb 18, 2023
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
|
Some of our tests are failing because part of the next-js install process downloads a binary from
At least that's how it seems. That isn't the fault of this pull, though it'd be nice to depend on them less so we aren't downloading very much or anything during CI. CR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default node version for the runners was changed to 18, which is not compatible with our current setup. Unfortunately, this change was only tracked as an issue and was not announced on GitHub's blog (https://github.blog/changelog/label/actions/), which is why we did not notice it.
In order to fix this, we need to explicitly set the node version to 16 for all our workflows that use node/pnpm.
QA Notes:
qa_req 0 CI should pass
References:
actions/runner-images#7002
https://ifixit.slack.com/archives/C02SMF0AZPF/p1676677777249139