Prepare new HEAD release based on LCG_101 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
pytorch-integration
branch
2 times, most recently
from
6196d3c to
239ac83
Compare
tmadlener
changed the title
tmadlener
force-pushed
the
pytorch-integration
branch
2 times, most recently
from
028e946 to
2bee006
Compare
tmadlener
force-pushed
the
pytorch-integration
branch
from
2bee006 to
8ac2bdf
Compare
|
triggering CI |
Some of the packages have cmake configurations that break starting with 3.17 if we want to build documentation. As a workaround we disable them for now until all these packages are fixed.
tmadlener
force-pushed
the
pytorch-integration
branch
from
8866c45 to
2ae5aa0
Compare
tmadlener
force-pushed
the
pytorch-integration
branch
from
2ae5aa0 to
81a3a0b
Compare
tmadlener
changed the title
tmadlener
commented
Mar 7, 2022
ilcsoft/ilcsoft.py
Outdated
Comment on lines
437
to
440
| # copy the PYTHONPATH verbatim from the build setup if it is set | ||
| python_path = os.getenv('PYTHONPATH') | ||
| if python_path: | ||
| f.write('export PYTHONPATH=' + python_path) |
There was a problem hiding this comment.
@andresailer would something like this break the nightly builds? Or do they also start from a "clean" environment?
There was a problem hiding this comment.
The nightly builds in /cvmfs/clicdp.cern.ch start from a clean environment, as in not using init_ilcsoft for setting up the build environment.
tmadlener
force-pushed
the
pytorch-integration
branch
from
c5a2427 to
b2c160b
Compare
Not as easily possible for me to just merge PRs there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Some things that still need to happen:
INSTALL_DOC=ONRootMacros.cmakeand theRootTestDriver.cmakescripts are not copied (at all). This can be fixed by manually symlinking/copying them from thecmake/modulesto thecmakedirectory. It is not entirely clear to me whether this is the only thing that is breaking in the in-source installation, but it is the one that is noticeable in dependent packages.