Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Configure RSpec to run sans monkeypatches #35

Merged
merged 3 commits into from
Jan 20, 2022
Merged

test: Configure RSpec to run sans monkeypatches #35

merged 3 commits into from
Jan 20, 2022

Conversation

olleolleolle
Copy link
Contributor

This PR removes RSpec top-level includes into Object etc.

@iMacTia
Copy link
Owner

iMacTia commented Jan 13, 2022

Failing because Style/SymbolProc: Pass &:disable_monkey_patching! as an argument to configure instead of a block..
But in this specific case, I'd rather keep it as it is because it will make it easier to add more configuration in future.
Feel free to ignore the cop with # rubocop:disable Style/SymbolProc on that line

@olleolleolle
Copy link
Contributor Author

@iMacTia That took some trying, haha, please do smash these commits together!

iMacTia
iMacTia approved these changes Jan 20, 2022
View reviewed changes
Copy link
Owner

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice addition 🙏 💯 !

@iMacTia iMacTia merged commit 5545f16 into iMacTia:master Jan 20, 2022
@olleolleolle olleolleolle deleted the rspec-details branch January 20, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olleolleolle @iMacTia