Fix deprecated ActiveRecord::LogSubscriber#runtime method
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the deprecation warning introduced in rails/rails#46041 Fixes #54
|
Kudos, SonarCloud Quality Gate passed!
|
iMacTia
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thank you @bolah2009 for fixing this issue 🙇!
I had a quick look and it seems like the old ActiveRecord::LogSubscriber.runtime was just a proxy to ActiveRecord::RuntimeRegistry.sql_runtime, so no surprise all tests are passing 🙌
bolah2009
deleted the
bb/fix-deprecated-rails-7-1-log-subscriber-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the deprecation warning introduced in rails/rails#46041
Fixes #54