Adjust Atlantic Electrical Heater to new standards and fix issues #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillstaff
reviewed
Jun 1, 2021
tillstaff
reviewed
Jun 1, 2021
iMicknl
added a commit
that referenced
this pull request
Jul 14, 2021
commit 93a02ff Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:30:49 2021 -0700 Add support for AtlanticElectricalTowelDryer (#423) * Add scaffold for feature/AtlanticElectricalTowelDryer * Update presets and other features * First clean up * remove comments commit a4709cd Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:18:00 2021 -0700 Adjust Atlantic Electrical Heater to new standards and fix issues (#454) * Adjust Atlantic Electrical Heater to new standards and fix issues * Add comfort mode * Add missing extra comfort presets commit 65de131 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 13:41:35 2021 -0700 Add more information regarding Model and Manufacturer (#474) commit 76d566c Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 11:56:06 2021 -0700 Improve reauth, Config Flow and error handling (#452) commit 847ee29 Author: Thibaut <thibaut@etienne.pw> Date: Wed Jul 14 19:09:43 2021 +0200 Fix is_opening/closing for RTS devices (#464) Co-authored-by: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> commit 560db42 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 10:01:12 2021 -0700 Update pyhoma and require latest Home Assistant version (#473)
iMicknl
added a commit
that referenced
this pull request
Jul 14, 2021
commit 4a77161 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:52:07 2021 -0700 Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362) commit 93a02ff Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:30:49 2021 -0700 Add support for AtlanticElectricalTowelDryer (#423) * Add scaffold for feature/AtlanticElectricalTowelDryer * Update presets and other features * First clean up * remove comments commit a4709cd Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:18:00 2021 -0700 Adjust Atlantic Electrical Heater to new standards and fix issues (#454) * Adjust Atlantic Electrical Heater to new standards and fix issues * Add comfort mode * Add missing extra comfort presets commit 65de131 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 13:41:35 2021 -0700 Add more information regarding Model and Manufacturer (#474) commit 76d566c Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 11:56:06 2021 -0700 Improve reauth, Config Flow and error handling (#452) commit 847ee29 Author: Thibaut <thibaut@etienne.pw> Date: Wed Jul 14 19:09:43 2021 +0200 Fix is_opening/closing for RTS devices (#464) Co-authored-by: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> commit 560db42 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 10:01:12 2021 -0700 Update pyhoma and require latest Home Assistant version (#473) commit 242e21d Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 08:01:55 2021 -0700 Currently stale issues are closed too soon (#470) commit c467aa4 Author: Thibaut <thibaut@etienne.pw> Date: Tue Jun 29 17:13:52 2021 +0200 Fix is_opening/is_closing for RTS covers (#463) commit 60f0766 Author: Thibaut <thibaut@etienne.pw> Date: Mon Jun 21 09:17:18 2021 +0200 Support is_opening/closing when moving position (#460) commit 39f485e Author: Thibaut <thibaut@etienne.pw> Date: Mon May 31 17:27:48 2021 +0200 Remove setPosition (#455)
iMicknl
added a commit
that referenced
this pull request
Jul 14, 2021
commit 1bbacf1 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 15:14:39 2021 -0700 Add basic support for AtlanticPassAPCHeatingAndCoolingZone (#380) commit 4a77161 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:52:07 2021 -0700 Adds basic support for AtlanticElectricalHeaterWithAdjustableTemperatureSetpoint (#362) commit 93a02ff Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:30:49 2021 -0700 Add support for AtlanticElectricalTowelDryer (#423) * Add scaffold for feature/AtlanticElectricalTowelDryer * Update presets and other features * First clean up * remove comments commit a4709cd Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 14:18:00 2021 -0700 Adjust Atlantic Electrical Heater to new standards and fix issues (#454) * Adjust Atlantic Electrical Heater to new standards and fix issues * Add comfort mode * Add missing extra comfort presets commit 65de131 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 13:41:35 2021 -0700 Add more information regarding Model and Manufacturer (#474) commit 76d566c Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 11:56:06 2021 -0700 Improve reauth, Config Flow and error handling (#452) commit 847ee29 Author: Thibaut <thibaut@etienne.pw> Date: Wed Jul 14 19:09:43 2021 +0200 Fix is_opening/closing for RTS devices (#464) Co-authored-by: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> commit 560db42 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 10:01:12 2021 -0700 Update pyhoma and require latest Home Assistant version (#473) commit 242e21d Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Wed Jul 14 08:01:55 2021 -0700 Currently stale issues are closed too soon (#470) commit c467aa4 Author: Thibaut <thibaut@etienne.pw> Date: Tue Jun 29 17:13:52 2021 +0200 Fix is_opening/is_closing for RTS covers (#463) commit 60f0766 Author: Thibaut <thibaut@etienne.pw> Date: Mon Jun 21 09:17:18 2021 +0200 Support is_opening/closing when moving position (#460) commit 39f485e Author: Thibaut <thibaut@etienne.pw> Date: Mon May 31 17:27:48 2021 +0200 Remove setPosition (#455)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @tillstaff in, there are some bugs in the Atlantic Electrical Heater implementation.
#408