Split entity between entity and executor logic [refactor] #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetienne
previously approved these changes
Aug 10, 2021
commit 9505d8c Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 02:03:19 2021 -0700 Add sensors dynamically based on available device state (#425) * Add temporary state sensor * Add extra sensors * Add more states * Add more sensors * Create supported_platforms variable * Use Overkiz label as device name * Suffix state sensor name with device index * Avoid to duplicate state key * Remove now usless rssi level attribute * Migrate LightSensor to TahomaStateSensor * Apply linters * Add PriorityLockOriginatorState sensor * Bump minimum version to 2021.8 * Remove unneeded value key * Migrate to SensorEntityDescription * Small tweaks * Add battery level * Remove unused state keys * Test electricity sensor * Add extra sensors * Add sensor * Add all sensors from sensor.py * Add smoke text sensor * Make optional * Change all sensor to new structure * Improve sensor definitions * Ease state * Ease retrieve of the index * Rollback device_state_attributes * Revert battery changes * Remove const * Add LightSensor * Rollback icon logic in cover * Bugfixes * Add round for RSSI value Co-authored-by: Thibaut Etienne <thibaut@etienne.pw> commit e7a4554 Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 01:56:39 2021 -0700 Add binary sensors dynamically based on available device state (#505) * Refactor binary sensor * Make import relative * Style fix * Update custom_components/tahoma/__init__.py Co-authored-by: Thibaut <thibaut@etienne.pw> * Add extra binary sensors * Clean for final PR * Feedback applied Co-authored-by: Thibaut <thibaut@etienne.pw> commit da5b26e Author: Mick Vleeshouwer <Mick.Vleeshouwer@microsoft.com> Date: Tue Aug 10 01:34:16 2021 -0700 Temporary bugfix for AwningValance (until this is fixed serverside) (#511) * Temporary bugfix for #486 * Add note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry in advance, this PR will be huge to review. I am trying to pull back the changes we had to make for core, in our custom component.
Core reviewers gave feedback that we should put the 'non entity' logic in a separate executor.. See https://github.com/home-assistant/core/tree/rework-tahoma/homeassistant/components/overkiz.
Already starting to rename some parts to Overkiz.