Revert "Fix number entity in 2022.1.0dev" #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8da903f.
|
Can we perhaps try to fix this based on the current HA version? |
|
We added a new property, how can we make this backward compatible? |
iMicknl
reviewed
Jan 26, 2022
Comment on lines
+84
to
+92
| @property | ||
| def min_value(self) -> float: | ||
| """Return the minimum value.""" | ||
| return self.entity_description.min_value or self._attr_min_value | ||
|
|
||
| @property | ||
| def max_value(self) -> float: | ||
| """Return the maximum value.""" | ||
| return self.entity_description.max_value or self._attr_max_value |
There was a problem hiding this comment.
I think we could check here for the HA version and otherwise just call super?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #667
This PR was merged too soon. Plus we will have to enfore the minimum required HA version.