Add support for "setRGB" command for light entity. #75
Conversation
vlebourl
added
enhancement
|
Don't we need to pull this from the states as well? To show the current color. |
|
Indeed we do. Added in the last commit. |
custom_components/tahoma/light.py
Outdated
|
|
||
| if ATTR_HS_COLOR in kwargs: | ||
| rgb = color_util.color_hs_to_RGB(*kwargs[ATTR_HS_COLOR]) | ||
| self._rgb = [int(float(c)) for c in rgb] |
There was a problem hiding this comment.
Can we already set self._rgb here? What if the command fails, in that case the state is incorrect?
Or should we implement this behavior in all integrations, where we directly update the state, but change it back if the command fails. (which happens via the update() function)
There was a problem hiding this comment.
This is one still applies, but is now renamed to self._hs_color
There was a problem hiding this comment.
Agreed, self._hs_color should be set in the update triggered after the turn_on, now that the command awaits for its completion.
There was a problem hiding this comment.
isn't that the same for _brightness and _effect though?
There was a problem hiding this comment.
You are right, let's keep it for now to have the same behavior across this integration.
There was a problem hiding this comment.
ok, let me push that and we can merge.
#Related Github issues: #75
fix issue #73