Refactor Alarm Control Panel #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
force-pushed
the
enhancement/refactor_alarm_control_panel
branch
from
ea9e4a0
to
841b8be
Compare
iMicknl
commented
Feb 21, 2022
Comment on lines
47
to
50
| OverkizCommandParam.OFF: STATE_ALARM_DISARMED, | ||
| "zone1": STATE_ALARM_ARMED_HOME, | ||
| "zone2": STATE_ALARM_ARMED_NIGHT, | ||
| OverkizCommandParam.TOTAL: STATE_ALARM_ARMED_AWAY, |
There was a problem hiding this comment.
I will need to add zone1 and zone2 to pyoverkiz. This is not according to Somfy spec. It should be partial1 and partial2, but in my and other users tests it seems that they use zone instead of partial.
tetienne
previously approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.