Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Dark theme, UI elements unification, UX enhancements #2207

Draft
wants to merge 221 commits into
base: master
Choose a base branch
from

Conversation

bfmvsa
Copy link
Contributor

@bfmvsa bfmvsa commented Oct 14, 2024

THIS IS DRAFT, please do not merge since some parts of this huge PR is still in progress.

Please Note: I didn't test these changes in Windows, because I do not have this OS, if there are any problems please send me screenshots.

I'm going to write detailed docs for all changes. But for now this short description is:
Mostly all changes are cosmetic, the biggest UX changes were in Failsafe tab (simplified visual part).
In this PR I use bootstrap sass framework for unification UI elements like buttons, tables, lists, etc. Also, it supports dark themes out of the box. However, developers still can use regular CSS files as they used to be.

Apart from Dark/Light theme, I've added an inverted sidebar & header according to this reasonable request.

Some screenshots:
screenshot 2024-10-14 at 18 22 51
screenshot 2024-10-14 at 18 22 37
screenshot 2024-10-14 at 18 25 24

[14 October '24]
Not ready tabs:

  1. SITL
  2. Mixer
  3. Outputs
  4. Tuning
  5. Programming
  6. LED Strip

Ready for testing tabs:

  1. Welcome
  2. Mission Control
  3. Firmware Flasher
  4. Status
  5. Calibration
  6. Ports
  7. Configuration
  8. Failsafe
  9. Advanced Tuning
  10. Receiver
  11. Modes
  12. Adjustments
  13. GPS
  14. Alignment Tool
  15. OSD
  16. Sensors
  17. Tethered Logging
  18. Blackbox
  19. CLI
  20. Options

@bfmvsa bfmvsa marked this pull request as draft October 14, 2024 16:35
@bfmvsa
Copy link
Contributor Author

bfmvsa commented Oct 14, 2024

Added responsive "screen" in the OSD tab
screenshot 2024-10-14 at 18 41 21

Changed behavior of "helpicon" when it is actually a link (In my opinion it was not obvious that this is the external link)
asd

Changed behavior of "Highlight profiles" checkbox, now it works without "reloading" of page
high

Simplified Failsafe tab UI, now you do not see any inputs if they do not needed for current procedure
screenshot 2024-10-14 at 18 51 22
screenshot 2024-10-14 at 18 51 30

Mobile friendly design (at least elements should not be overlapping each other)
screenshot 2024-10-14 at 18 54 23

Unified styles and design tokens across the app
screenshot 2024-10-14 at 18 59 50

And a lot of other fixes/improvements, everything will be described in docs

@trailx
Copy link

trailx commented Oct 17, 2024

I appreciate the UI changes you've been working on. Looks like a lot of small positive changes! To clarify since you're talking about a mobile-friendly design, will this become a web-app like betaflight's configurator? or is it still going to be a standalone app only?

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Oct 18, 2024

@trailx This is still a standalone app, when I say "mobile friendly" I mean it looks ok and is usable on narrow screens. In other words, It has a responsive design.

@trailx
Copy link

trailx commented Oct 20, 2024

@bfmvsa I gotcha, I wasn't sure if there was something I had missed. There are often times when I use it half screen, so just being more responsive to window size will be nice!

Since you're in there, one idea that came up in a discussion was creating a button in the blackbox tab that would put the FC into MSC mode. Betaflight has this, and it's handy rather than having to look it up on GitHub every time. This seems like a relatively easy add and would bring more attention to the MSC function. Since you're working on the UI, you seemed like the best person to bring this up to. Thanks for the consideration!

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Oct 20, 2024

@trailx It looks like somebody was trying to add this button (at least it is presented on the tab). But if I am not mistaken this button is not working (always disabled and there are no any click handlers for this button), also this button is added only for SD cards, need it also for onboard dataflash chip.
As a part of this huge PR I decided to not change the current logic a lot, but in the future your suggestion will be implemented, this is already in my todo list :)
screenshot 2024-10-20 at 17 11 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants