Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify HMC5883 dirver #2809

Merged
merged 3 commits into from
Feb 22, 2018
Merged

Simplify HMC5883 dirver #2809

merged 3 commits into from
Feb 22, 2018

Conversation

digitalentity
Copy link
Member

@digitalentity digitalentity commented Feb 21, 2018

PoC implementation 9b02f455c7bf54c69f232c3b008bdc9f7664e4fa by @andrejpodzimek.

I've done some tests and it looks like magGain calculated in HMC5883 driver is between 0.8 and 1.0. Not applying per-axis gains may result in non-linearity of heading. In worst case it may lead to heading error of about 6 degrees which is probably acceptable - compass alignment error is likely to be bigger.

References: #2619 (comment), #2558, #2299

andrejpodzimek and others added 2 commits February 21, 2018 21:27
…alibration of HMC5883 chip, use default values.

Co-authored-by: Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>
@digitalentity digitalentity added this to the 1.9 milestone Feb 21, 2018
@digitalentity digitalentity changed the base branch from master to development February 21, 2018 11:43
@stronnag
Copy link
Collaborator

Flight tested on 0d51ca3 + #2809 as diff + QUARKVISION target files, (QVF4). Beitian BN880 (M8N/5883).
Works just fine. Probably not distinguishable from prior driver.

@giacomo892
Copy link
Collaborator

Flown the same on OMNIBUS F3. All perfect.
To be noted that 0d51ca3 isn't going to impact MR but FW without BARO. But should cause no issues.

@stronnag
Copy link
Collaborator

It doesn't (affect MR), not even a placebo "AH was fantasic!!!!" (which it was, as usual). Just happened to be dev HEAD.

@giacomo892
Copy link
Collaborator

@stronnag eheheh. I'm still struggling to get a perfect altitude holding :) But that's another matter. I would like if you post a video of a your machine where it holds altitude for a minute in PH/AH mode :) So I can compare to mine. Thanks!

@stronnag
Copy link
Collaborator

@giacomo892 Sure. Videos are NOT my forte, but I'll try and remember next time.

@digitalentity
Copy link
Member Author

Good!

@digitalentity digitalentity merged commit f8c76a0 into development Feb 22, 2018
@digitalentity digitalentity deleted the de_hmc5883_remove_gain branch February 22, 2018 07:50
@alanfj
Copy link

alanfj commented Feb 23, 2018

I just tried the latest INAV Beta 1.9 on my OmnibusF4SD using the OmnibusF4PRO target and the “compass” still does not work. I have 2 of these Radiolink SE100’s, that I bought new in January ’18, and even reversed the polarity and still get nothing. Went into CLI and made sure it was set manually to QMC5883. The “GPS” functions properly. In AUTO it is still recognized as the HMC5883.

@dleask
Copy link

dleask commented Feb 24, 2018

I’ve ended up returning the unit I bought as the stated HMC5833L chip is clearly a clone/copy. Manually setting the QMC5833 doesn’t show a magnetometer is detected. Looking inside the unit, it appears the mag chip has been painted over to stop visual identification.

@ghost
Copy link

ghost commented Feb 24, 2018

@dleask
Who did you buy your SE100 from?
From my own personnel experience and the numerous problems reported in various forums about this product, it appears that Radio Link are up to all sorts of Chinese smoke and mirror tricks in an attempt to cover up a major design/production screw up.
I bought mine from BG and I am going to recommend that they discontinue this product, and preferably, all other products from this company.

@alanfj
Copy link

alanfj commented Feb 24, 2018

My (2) Radiolink SE100's were purchased from Banggood. They each have the DA5883 mag chip in them. Still hoping I can eventually use them. I'll keep my fingers crossed that it all gets worked out. digitalentity is a smart fellow and so are his associates. :)

@kingdraki
Copy link

Same here, SE100 from Banggood with DA5883. Does not work as HMC5883, as which it is detected. And does not work as QMC5883. Inav sets Mag label in the upper bar red then.

@dleask
Copy link

dleask commented Feb 24, 2018

Mine was from a UK eBay seller, there seems to be a lot with the same description containing a reference to HMC5833L magnetometer.

This is the new Ublox Neo-M8N GPS module that includes a HMC5883L digital compass. This module has a high level of sensitivity and features active circuitry for the ceramic patch antenna. It also comes enclosed in plastic case to protect the module from the elements. This modules outputs precise position updates at 10Hz and also has a rechargeable backup battery for warm starts. The Ublox NEO-M8N is configured to run at a baud rate of 38400 and ships for use with Pixhawk and APM (you might need to modify the cable to fit your autopilot board).

@alanfj
Copy link

alanfj commented Feb 25, 2018

Not working on target OmnibusF4PRO. digitalentity is making the fix for INAV 1.90 RC2

@kingdraki
Copy link

Ok, just saw #2299 . I have also OmnibusF4 pro.

@alanfj
Copy link

alanfj commented Feb 26, 2018

digitalentity has made the fix with the release today of INAV 1.90 RC2. I tried it and it works exceedingly well. The Radiolink SE100 works fantastically! Thanks digitalentity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants