Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all MAX7456 specific code, replace it with generic interfaces #4384

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

fiam
Copy link
Member

@fiam fiam commented Feb 17, 2019

  • Rename max7456_symbols.h to osd_symbols.h. We'll expect all supported
    OSD drivers to use the same font style.
  • Introduce drivers/osd.h, which defines the supported video systems
    and the format for the OSD characters that all drivers must support.
  • Remove drivers/vcd.h, since having a file for a single enum is
    kind of annoying, move this enum to the new drivers/osd.h file.
  • Add osdGetDisplayPort() for retriving the display port used by
    the OSD.
  • Add a new display function named writeFontCharacter() which takes
    a character address and its data.
  • Use the aforementioned 2 functions to implement character font
    uploading in fc_msp.c, so it's not MAX7456-specific anymore.

@fiam fiam added this to the 2.2 milestone Feb 17, 2019
@fiam fiam force-pushed the agh_remove_hardcoded_max7456 branch 3 times, most recently from 96a1f9d to 75da202 Compare March 10, 2019 21:33
- Rename max7456_symbols.h to osd_symbols.h. We'll expect all supported
OSD drivers to use the same font style.
- Introduce drivers/osd.h, which defines the supported video systems
and the format for the OSD characters that all drivers must support.
- Remove drivers/vcd.h, since having a file for a single enum is
kind of annoying, move this enum to the new drivers/osd.h file.
- Add osdGetDisplayPort() for retriving the display port used by
the OSD.
- Add a new display function named writeFontCharacter() which takes
a character address and its data.
- Use the aforementioned 2 functions to implement character font
uploading in fc_msp.c, so it's not MAX7456-specific anymore.
@fiam fiam force-pushed the agh_remove_hardcoded_max7456 branch from 75da202 to 9829ba4 Compare March 15, 2019 10:08
@fiam fiam merged commit e52b5d9 into development Mar 15, 2019
@fiam fiam deleted the agh_remove_hardcoded_max7456 branch March 15, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant