-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change VTX power level via switch #4717
Conversation
While i wait for approval or changes, iNav Configurator PR: #775 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch upon the development branch and fix the indentation. We are using 4 spaces per level and no tabs.
Otherwise looking good to me
Thank you @shellixyz After some mess i should have rebased correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you originally based your branch upon master it picked up 3747ca4 but it is not a big deal. LGTM
Complement to iNavFlight#4717. It is now possible to change the VTX power setting in flight. This allows to see what power the VTX is set at and also when the VTX power RC adjustment is active.
Complement to iNavFlight#4717. It is now possible to change the VTX power setting in flight. This allows to see what power the VTX is set at and also when the VTX power RC adjustment is active.
Complement to #4717. It is now possible to change the VTX power setting in flight. This allows to see what power the VTX is set at and also when the VTX power RC adjustment is active.
This working now? (Change vtx power via swith) |
Hi,
this PR allow user to change VTX power during the flight.
I used "Adjustments" mechanism to avoid huge modification to iNav's code.
I'm not sure in "rc_adjustments.c" if it's correct to use "VTX_SETTINGS_MIN_POWER" and "VTX_SETTINGS_MAX_POWER" to constrain the variable which sets the power level.
My advice is to use a 3-pos switch or a potentiometer and set the same channel in "Range Channel" and "Adjustment Channel".
I tested it only on my Eachine Smartaudio VTX.
Note: i have PR ready for inav-configurator to add this feature. I'll wait for this to get accepted before proposing that.
EDIT: iNav Configurator PR #775