Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VTX power level via switch #4717

Merged
merged 3 commits into from
May 23, 2019

Conversation

L4ky
Copy link
Contributor

@L4ky L4ky commented May 17, 2019

Hi,
this PR allow user to change VTX power during the flight.
I used "Adjustments" mechanism to avoid huge modification to iNav's code.

I'm not sure in "rc_adjustments.c" if it's correct to use "VTX_SETTINGS_MIN_POWER" and "VTX_SETTINGS_MAX_POWER" to constrain the variable which sets the power level.

My advice is to use a 3-pos switch or a potentiometer and set the same channel in "Range Channel" and "Adjustment Channel".

I tested it only on my Eachine Smartaudio VTX.

Note: i have PR ready for inav-configurator to add this feature. I'll wait for this to get accepted before proposing that.

EDIT: iNav Configurator PR #775

@fiam fiam changed the base branch from master to development May 17, 2019 22:52
@L4ky
Copy link
Contributor Author

L4ky commented May 21, 2019

While i wait for approval or changes, iNav Configurator PR: #775

Copy link
Collaborator

@shellixyz shellixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch upon the development branch and fix the indentation. We are using 4 spaces per level and no tabs.

Otherwise looking good to me

@L4ky
Copy link
Contributor Author

L4ky commented May 21, 2019

Thank you @shellixyz

After some mess i should have rebased correctly.

Copy link
Collaborator

@shellixyz shellixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you originally based your branch upon master it picked up 3747ca4 but it is not a big deal. LGTM

@shellixyz shellixyz added this to the 2.2 milestone May 21, 2019
@shellixyz shellixyz merged commit 732e118 into iNavFlight:development May 23, 2019
shellixyz added a commit to shellixyz/inav that referenced this pull request May 23, 2019
Complement to iNavFlight#4717. It is now possible to change the VTX power setting
in flight. This allows to see what power the VTX is set at and also when
the VTX power RC adjustment is active.
shellixyz added a commit to shellixyz/inav that referenced this pull request May 24, 2019
Complement to iNavFlight#4717. It is now possible to change the VTX power setting
in flight. This allows to see what power the VTX is set at and also when
the VTX power RC adjustment is active.
shellixyz added a commit that referenced this pull request May 25, 2019
Complement to #4717. It is now possible to change the VTX power setting
in flight. This allows to see what power the VTX is set at and also when
the VTX power RC adjustment is active.
@whoim2
Copy link

whoim2 commented Oct 2, 2019

This working now? (Change vtx power via swith)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants