Update widgets at midnight #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianTashkov
force-pushed
the
refresh_widgets_at_midnight
branch
from
1b65329 to
ea6ca15
Compare
iSoron
requested changes
Sep 5, 2020
There was a problem hiding this comment.
Thanks for the pull request, @KristianTashkov. It looks good to me. I had only some minor comments.
| @@ -175,9 +175,14 @@ public static long getStartOfToday() | |||
| return getStartOfDay(getLocalTime()); | |||
| } | |||
|
|
|||
| public static long getTomorrowStart() | |||
There was a problem hiding this comment.
For consistency, please rename this to getStartOfTomorrow()
android/uhabits-core/src/test/java/org/isoron/uhabits/core/utils/DateUtilsTest.java
Show resolved
Hide resolved
iSoron
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently widgets don't get updated after midnight until you take an action on one of them.