🌍 Add google-earth filetype kml and update contributing
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add kml filetype on websearch - Add test for kml filetype - Add link for contributing
gaetan1903
reviewed
Oct 29, 2021
- Create a method for finding all filetype - Add test for custom - Add KML and CUSTOM to readme
fix default parameter
gaetan1903
approved these changes
Oct 30, 2021
websearch/script.py
Outdated
| self.__data['kml'] = (self.query, result) | ||
| return result | ||
|
|
||
| def custom_search(self, extension='pdf', mimetype='pdf'): |
There was a problem hiding this comment.
you change ext to mimetype, so you have to write 'application/pdf' not pdf only
|
J'ai mis le label hacktoberfest-accepted donc, cela sera compté dans ton hacktoberfest challenge, Je mergerai quand j'aurais trouvé le soucis du test, cela n'est pas lié à ton code apparement, |
gaetan1903
reviewed
Oct 30, 2021
tests/test.py
Outdated
| self.assertTrue(len(documents)) | ||
| #verification lien | ||
| for doc in documents: | ||
| self.assertTrue(map.startswith('http')) |
There was a problem hiding this comment.
why you use map ? you mean doc, that's why test fail for custom_search
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gaetan1903 @rivo2302 please review my PR and add
hacktoberfest-acceptedtags 🚀