Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ogc3dtiles] Fix tests #2375

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

Desplandis
Copy link
Contributor

@Desplandis Desplandis commented Aug 2, 2024

This PR fixes test errors on the 3d-tiles-migration branch :

  • Revert original 3D Tiles examples to those on master
  • Add new 3D Tiles example for the new 3D Tiles implementation with picking support and zoom to tileset feature
  • Fix a linting issue in a unit test.

@Desplandis Desplandis force-pushed the ogc3dtiles/fix-tests branch 7 times, most recently from aafd7a0 to 1e5fb7a Compare August 7, 2024 13:29
@Desplandis
Copy link
Contributor Author

Rebased on #2376. Shall pass all tests.

@Desplandis Desplandis marked this pull request as ready for review August 7, 2024 13:30
@Desplandis Desplandis requested a review from jailln August 7, 2024 13:30
@jailln jailln force-pushed the ogc3dtiles/fix-tests branch from 1e5fb7a to 4c04ceb Compare August 8, 2024 09:31
examples/3dtiles_loader.html Show resolved Hide resolved
examples/3dtiles_loader.html Show resolved Hide resolved
examples/3dtiles_loader.html Outdated Show resolved Hide resolved
examples/3dtiles_loader.html Show resolved Hide resolved
examples/3dtiles_loader.html Show resolved Hide resolved
examples/3dtiles_loader.html Show resolved Hide resolved
examples/jsm/OGC3DTilesHelper.js Show resolved Hide resolved
examples/jsm/OGC3DTilesHelper.js Show resolved Hide resolved
@jailln jailln changed the base branch from 3d-tiles-migration to master August 8, 2024 15:41
@jailln jailln changed the base branch from master to 3d-tiles-migration August 8, 2024 15:44
@Desplandis Desplandis force-pushed the ogc3dtiles/fix-tests branch from 4c04ceb to 5ab4dc6 Compare August 8, 2024 20:12
@jailln jailln force-pushed the ogc3dtiles/fix-tests branch from ea76cf3 to 90c60f8 Compare August 9, 2024 07:45
@jailln jailln force-pushed the ogc3dtiles/fix-tests branch from 90c60f8 to 56a31b9 Compare August 9, 2024 07:47
@jailln jailln merged commit ead1a05 into iTowns:3d-tiles-migration Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants