ITwinui update 3.x #107

DanishMehmood-bit · 2023-11-17T11:45:34Z

Updated storybook to webpack 5
Updated storybook to support Babel v7
Updated itwinui to 3.x
Updated minimum supported node version to 18.14.0
Updated CI to run node 18 workflows
Fixed dark mode in storybook
Repo now targets es2020
Replaced node-sass with sass

packages/apps/storybook/.env

packages/modules/delete-itwin/src/components/DeleteITwin.test.tsx

…into DanishM/itwinui3_x

packages/apps/storybook/.storybook/preview.js

kckst8

lgtm

packages/modules/storybook-auth-addon/package.json

tsconfig.json

packages/modules/create-imodel/package.json

common/scripts/package.json

packages/apps/storybook/.storybook/main.js

packages/apps/storybook/src/imodel-browser/IModelGrid.stories.tsx

packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.tsx

kckst8 · 2023-11-29T13:46:21Z

Would be good not to merge it before this #99

@veekeys looks like #99 has been open for a month. Any idea when it will merge? This is a blocker for iTwin Studio (and all of its apps) to upgrade to iTwin 3

veekeys · 2023-11-29T14:12:34Z

Would be good not to merge it before this #99

@veekeys looks like #99 has been open for a month. Any idea when it will merge? This is a blocker for iTwin Studio (and all of its apps) to upgrade to iTwin 3

Yeah, sorry...
Not sure if we make it fast as we found critical issue there.
@Pooja17-bentley Any idea how long it will take you to finish up?

I did not come back to this PR, but I am concerned about so many css changes. That should not have been needed :/

Pooja17-bentley · 2023-11-29T14:33:08Z

Would be good not to merge it before this #99

@veekeys looks like #99 has been open for a month. Any idea when it will merge? This is a blocker for iTwin Studio (and all of its apps) to upgrade to iTwin 3

Yeah, sorry... Not sure if we make it fast as we found critical issue there. @Pooja17-bentley Any idea how long it will take you to finish up?

Apologies, tests are failing after some fixes, will try to fix and finish this soon.

Pooja17-bentley · 2023-11-30T12:20:54Z

Would be good not to merge it before this #99

@veekeys looks like #99 has been open for a month. Any idea when it will merge? This is a blocker for iTwin Studio (and all of its apps) to upgrade to iTwin 3

Yeah, sorry... Not sure if we make it fast as we found critical issue there. @Pooja17-bentley Any idea how long it will take you to finish up?

Apologies, tests are failing after some fixes, will try to fix and finish this soon.

Update - Done with my changes and PR is merged

…into DanishM/itwinui3_x

packages/apps/storybook/package.json

packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.tsx

packages/modules/imodel-browser/package.json

packages/apps/storybook/src/create-imodel/CreateIModel.css

packages/modules/create-imodel/src/components/base-imodel/BaseIModel.scss

packages/apps/storybook/src/create-imodel/CreateIModel.stories.tsx

packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinTile.tsx

packages/modules/imodel-browser/src/containers/iModelTiles/IModelGhostTile.tsx

packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.tsx

packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx

aruniverse

approving changes in files that i own (ci)

packages/modules/create-imodel/src/components/base-imodel/BaseIModel.scss

packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx

packages/modules/storybook-auth-addon/src/index.js

common/changes/@itwin/imodel-browser-react/DanishM-itwinui3_x_2023-11-20-07-14.json

raplemie

LGTM! Thanks!

DanishMehmood-bit added 6 commits November 14, 2023 12:06

Update itwinui => 3.x

c9c03ae

Auto changes using tool

6290029

Manual update

e2f540b

Webpack upgrade to 5 and babel to use v7

769797f

Style fixes

1e3c93b

Updated tests

9fc706b

ben-polinsky reviewed Nov 17, 2023

View reviewed changes

packages/apps/storybook/.env Outdated Show resolved Hide resolved

packages/modules/delete-itwin/src/components/DeleteITwin.test.tsx Show resolved Hide resolved

DanishMehmood-bit added 5 commits November 20, 2023 12:10

Merge branch 'main' of https://github.com/iTwin/admin-components-react …

b734a15

…into DanishM/itwinui3_x

Created changelogs

be7d098

Updated changes

a9f8011

Updated jest

0fc394f

Updated module to use es2020

b03ce15

raplemie reviewed Nov 20, 2023

View reviewed changes

packages/apps/storybook/.storybook/preview.js Show resolved Hide resolved

DanishMehmood-bit added 3 commits November 21, 2023 14:50

Fixed dark mode

1b78711

Minimum node supported version is now 14.17.3

0dce51a

Updated tslib and rollup typescript plugin

a29a5d2

DanishMehmood-bit marked this pull request as ready for review November 21, 2023 12:44

DanishMehmood-bit requested review from williamkbentley, veekeys, a team and kckst8 as code owners November 21, 2023 12:44

DanishMehmood-bit added 2 commits November 21, 2023 18:52

Updated minimum node version to 18.14.0

be96853

Reverting the changes back

4e8461d

kckst8 approved these changes Nov 21, 2023

View reviewed changes

Updated dependencies to support node 18

9176c52

aruniverse reviewed Nov 21, 2023

View reviewed changes

packages/modules/storybook-auth-addon/package.json Show resolved Hide resolved

aruniverse reviewed Nov 21, 2023

View reviewed changes

tsconfig.json Show resolved Hide resolved

aruniverse linked an issue Nov 21, 2023 that may be closed by this pull request

node 18 support #93

Closed

raplemie reviewed Nov 21, 2023

View reviewed changes

DanishMehmood-bit mentioned this pull request Nov 22, 2023

Use the itwin auth client instead of old deprecated bentley 2.x pkgs #109

Open

DanishMehmood-bit added 3 commits November 22, 2023 15:14

Updated eslint parsers

94cc28b

Refs now focus

6c80850

Module to esnext

5275c4a

Removed unused classes

c62d28b

Merge branch 'main' of https://github.com/iTwin/admin-components-react …

84582b3

…into DanishM/itwinui3_x

aruniverse reviewed Nov 30, 2023

View reviewed changes

packages/apps/storybook/package.json Show resolved Hide resolved

aruniverse reviewed Nov 30, 2023

View reviewed changes

packages/modules/imodel-browser/src/containers/iModelTiles/IModelTile.tsx Show resolved Hide resolved

aruniverse reviewed Nov 30, 2023

View reviewed changes

packages/modules/imodel-browser/package.json Outdated Show resolved Hide resolved

Moved itwinui-react as a dependency

9a0248f

veekeys reviewed Dec 1, 2023

View reviewed changes

DanishMehmood-bit force-pushed the DanishM/itwinui3_x branch from b2fddbd to 9a0248f Compare December 1, 2023 11:01

ITwinTile updated

3756261

aruniverse approved these changes Dec 1, 2023

View reviewed changes

Updated comments

55363aa

veekeys reviewed Dec 5, 2023

View reviewed changes

packages/modules/create-imodel/src/components/base-imodel/BaseIModel.scss Outdated Show resolved Hide resolved

veekeys approved these changes Dec 5, 2023

View reviewed changes

Removed extra space

07083a6

raplemie reviewed Dec 5, 2023

View reviewed changes

packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx Outdated Show resolved Hide resolved

raplemie reviewed Dec 5, 2023

View reviewed changes

packages/modules/storybook-auth-addon/src/index.js Outdated Show resolved Hide resolved

Removed nullish coalescing rule

236f7ba

raplemie reviewed Dec 6, 2023

View reviewed changes

common/changes/@itwin/imodel-browser-react/DanishM-itwinui3_x_2023-11-20-07-14.json Outdated Show resolved Hide resolved

Updated to minor + typecasting in manage versions

a0d6c1d

raplemie approved these changes Dec 6, 2023

View reviewed changes

williamkbentley approved these changes Dec 6, 2023

View reviewed changes

DanishMehmood-bit merged commit 524e2d9 into main Dec 6, 2023
4 checks passed

DanishMehmood-bit deleted the DanishM/itwinui3_x branch December 6, 2023 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITwinui update 3.x #107

ITwinui update 3.x #107

DanishMehmood-bit commented Nov 17, 2023 •

edited

Loading

kckst8 left a comment

kckst8 commented Nov 29, 2023

veekeys commented Nov 29, 2023

Pooja17-bentley commented Nov 29, 2023

Pooja17-bentley commented Nov 30, 2023

aruniverse left a comment

raplemie left a comment

ITwinui update 3.x #107

ITwinui update 3.x #107

Conversation

DanishMehmood-bit commented Nov 17, 2023 • edited Loading

kckst8 left a comment

Choose a reason for hiding this comment

kckst8 commented Nov 29, 2023

veekeys commented Nov 29, 2023

Pooja17-bentley commented Nov 29, 2023

Pooja17-bentley commented Nov 30, 2023

aruniverse left a comment

Choose a reason for hiding this comment

raplemie left a comment

Choose a reason for hiding this comment

DanishMehmood-bit commented Nov 17, 2023 •

edited

Loading