Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user column to Named versions and Changeset tables + changeset information panel #98

Merged
merged 14 commits into from
Nov 16, 2023
Merged

Added user column to Named versions and Changeset tables + changeset information panel #98

merged 14 commits into from
Nov 16, 2023

Conversation

Pooja17-bentley
Copy link
Contributor

@Pooja17-bentley Pooja17-bentley commented Oct 26, 2023 •
edited
Loading

  1. Added user column to both Named Versions and Changes table.
  2. Added Information panel for the changeset that includes- changeset id, description, created by, created date , application and Changed Files information.
    image

info-panel
changeset-table

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Pooja17-bentley Pooja17-bentley changed the title Pooja/add user column to version and changes tables Adding user column to Named versions and Changeset tables Oct 26, 2023
@Pooja17-bentley Pooja17-bentley changed the title Adding user column to Named versions and Changeset tables Added user column to Named versions and Changeset tables + changeset information panel Oct 30, 2023
veekeys
veekeys reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@veekeys veekeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent run it locally yet, probably should be able to simplify the panel...

packages/modules/manage-versions/src/components/ManageVersions/types.ts Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.scss Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.scss Outdated Show resolved Hide resolved
veekeys
veekeys reviewed Nov 8, 2023
View reviewed changes
packages/modules/manage-versions/src/components/ManageVersions/VersionsTab/VersionsTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/VersionsTab/VersionsTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/InformationPanel/ChangesetInformationPanel.tsx Outdated Show resolved Hide resolved
packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.scss Outdated Show resolved Hide resolved
@veekeys veekeys reopened this Nov 16, 2023
@veekeys veekeys merged commit a4fb572 into iTwin:main Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veekeys veekeys veekeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pooja17-bentley @CLAassistant @veekeys @aruniverse