Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels and end walls #414

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Channels and end walls #414

merged 3 commits into from
Dec 20, 2024

Conversation

BenTWhite
Copy link
Contributor

  1. fixed the properties on the curb inlet
  2. add a channel element along with channel shape aspects
  3. Added headwalls -

this includes an enumeration with wall the InletControl coefficients

along with various aspects that describe the different ways headwalls can be treated: Outfall, PondInflow, PondOutflow, Transition

@BenTWhite BenTWhite requested a review from a team as a code owner December 19, 2024 17:15
@diegoalexdiaz
Copy link
Contributor

Since version 1.0.0 was already released and the goal is to preserve compatibility with it going forward, that means that only minor schema changes are allowed. That is, changes that don't break any existing ECSQL queries written against the released version (i.e. read-compatibility).

Any deletion of a class or property is considered a major schema-update. This PR is deleting some schema content from the released schema: e.g.

  • CatchBasinTypeCurbInletHydraulicAspect.SlotWidth
  • CatchBasinTypeCurbInletHydraulicAspect.SlotLength
  • RectangularAspect class

In cases like these, you need to keep those properties/classes, but you can mark them "deprecated" and also hide them from the UX.

e.g.

<ECProperty propertyName=...>
  <ECCustomAttributes>
    <HiddenProperty xmlns="CoreCustomAttributes.01.00.03"/>
    <Deprecated xmlns="CoreCustomAttributes.01.00.03">
      <Description>TODO: Point existing readers of the deprecated property or class to how they can find the same data going forward. E.g. The new property or class.</Description>
    </Deprecated>
  </ECCustomAttributes>
</ECProperty>

@BenTWhite BenTWhite merged commit 5538c7b into master Dec 20, 2024
18 checks passed
@BenTWhite BenTWhite deleted the channels-and-end-walls branch December 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants