Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isFirstSynchronization to options #100

Closed
wants to merge 3 commits into from

Conversation

simsta6
Copy link
Contributor

@simsta6 simsta6 commented Jul 27, 2023

  • Added isFirstSynchronizations to options
  • Made shouldDetectDeletes method protected

If source iModel had different external source aspects, they were imported to target. Then at the end of transformation detectElementsDeletes was called. It would detect that some elements should be deleted, because transformer would get random identifier values, example:
image

@MichaelBelousov
Copy link
Contributor

MichaelBelousov commented Jul 27, 2023

If source iModel had different external source aspects, they were imported to target. Then at the end of transformation detectElementsDeletes was called. It would detect that some elements should be deleted, because transformer would get random identifier values,

We shouldn't introduce this "new option" because the transformer is going to expose a higher-level Branching API soon, including an initBranch API which would supersede this. Also, it appears that you're adding this because you're not using wasSourceIModelCopiedToTarget in the branch initialization, which is not supported by the transformer.

@simsta6 simsta6 closed this Jul 27, 2023
@MichaelBelousov
Copy link
Contributor

Also adding, it seems the bug this was fixing was due to a default targetScopeElement 0x1 which conflicted with the scope of ExternalSourceAspect's added by others. The default of targetScopeElement is very bad and the default will be removed in 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants