-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transitively pinned minimatch 3.0.4 dependency is causing rush audit to fail. #4524
Comments
the transitive dep pinning this so I'm not sure how long or if they will provide an update. @aruniverse you expressed being concerned that our build-tool consumers would need any override we ourselves add to our package manager. does not seem to be any contributor response yet to this issue. |
also as a note, this is a create-react-app transitive dependency because the dependency path goes through |
i didn't realize this was also a transitive dep coming from cra... thats going to be a pain. @mattbjordan @evelynpreslar-bentley would be nice to refactor out the need for the |
@aruniverse How much of a hassle is it to fork or copy the |
I do not want to fork and continuously maintain them. the one fork we have now is already a pain |
Describe the bug
Our transitive dependencies now include minimatch@3.0.4 which has a ReDos vulnerability
GHSA-f8q6-p94x-37v3
To Reproduce
run rush audit in master. You'll fail on this:
GHSA-f8q6-p94x-37v3
Expected behavior
No failure
Additional context
we could use
pnpm.overrides
but we'd have to upgrade ourrush
version and downstream consumers of our build tools will still have to manually fix.The text was updated successfully, but these errors were encountered: