-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimatch@3.0.4 to minimatch@3.0.5 #85
Conversation
high severity vulnerability in minimatch@3.0.4, update to 3.0.5
@jergason sorry to reach out directly, but this vulnerability has been sitting unresolved for some time. Would you mind taking a look? Thanks |
package.json
Outdated
@@ -23,7 +23,7 @@ | |||
"node": ">=6.0.0" | |||
}, | |||
"dependencies": { | |||
"minimatch": "3.0.4" | |||
"minimatch": "3.0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid future issues, would it make sense to use "^3.0.5"
instead?
Thank you for opening this... I was chasing down the same issue. |
@jergason , could you please apply this patch, it's lingering for a long time. In our react project, react-dev-utils has a transitive dependency on recursive-readdir which uses minimatch 3.0.4 vulnerable version. Maintainer, could you please upgrade minimatch to the latest version? |
@jergason Is there anything we can assist you to get this security fix integrated? |
👋 Hello from another automated dependency scan re: CVE-2022-3517! While we wait, maybe npm overrides can help:
If you don't mind minor updates to other dependencies, delete the An alternative is to run
Good luck! |
If no owner responds we should consider forking this repository and updating the dependency. |
@imki123 trust me I would have merged this months ago if I had write access... |
+1 this needs to be merged. |
just tested this locally, tests pass - I can merge this and publish. |
Thanks @bnb for the merge and publish of |
Thank you !! 👍 |
High severity vulnerability in minimatch@3.0.4, update to 3.0.5 per #83
Vulnerability description:
minimatch package versions before 3.0.5 are vulnerable to Regular Expression Denial of Service (ReDoS). It's possible to cause a denial of service when calling function braceExpand (The regex /\{.*\}/ is vulnerable and can be exploited).
FWIW: Added minimatch@3.0.5 as resolution to package.json file, recursive-readdir continues to work with this update.