Add ability to initialize Presentation with custom props #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
requested review from
aruniverse,
ben-polinsky and
calebmshafer
as code owners
|
Looks good to me. We'll need to mitigate this audit failure: ERROR: HIGH Security Vulnerability: Path traversal in webpack-dev-middleware in webpack-dev-middleware (from ..__..__packages__apps__desktop-viewer-test>@bentley/react-scripts>webpack-dev-server>webpack-dev-middleware). See GHSA-wr3j-pwj9-hqq6 for more info. |
ben-polinsky
approved these changes
May 23, 2024
aruniverse
reviewed
May 23, 2024
aruniverse
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to supply custom props to use during Presentation initialization. This is need to allow supplying new unified selection storage to be used by presentation-frontend.
Remove code setting active locale as it is done by default when initializing Presentation: https://github.com/iTwin/itwinjs-core/blob/73187a864fe12a1ca44d38f799bc9a2d79dfa40a/presentation/frontend/src/presentation-frontend/Presentation.ts#L74