Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight query seed genes / paths #389

Closed
ugurdogrusoz opened this issue Mar 14, 2019 · 3 comments
Closed

Highlight query seed genes / paths #389

ugurdogrusoz opened this issue Mar 14, 2019 · 3 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@ugurdogrusoz
Copy link
Contributor

ugurdogrusoz commented Mar 14, 2019

We should try to highlight as much of the query seed genes / paths as possible with each query using the newly implemented highlight feature.

@ugurdogrusoz ugurdogrusoz added the feature New feature or request label Mar 14, 2019
@ugurdogrusoz ugurdogrusoz assigned umut-er and unassigned meneskaraca Jun 5, 2024
@ugurdogrusoz ugurdogrusoz added this to the version 4.0 milestone Jun 11, 2024
@umut-er
Copy link
Contributor

umut-er commented Jun 12, 2024

I am currently using cytoscape.js-graph-algos to implement highlighting. I found that there is some incongruency between how pathway commons does the common stream queries and how cytoscape.js-graph-algos does common stream queries.
When I query pathway commons for the common stream of PTEN and TP53, pathway commons returns nodes if at least one node that has "PTEN" in its label and at least one node that has "TP53" in its label have access to the node within specified length limits. However, if I query cytoscape.js-graph-algos with all PTEN and TP53 nodes as source, the algorithm only returns nodes if ALL nodes named PTEN and TP53 have access to the same node within specified length limits.
This is problematic because in the context of a pathway commons query because those usually return lots of nodes named "PTEN" and "TP53".
All of this means that there needs to be some additional functionality in the cytoscape.js-graph-algos extension to accommodate this. I can look into it.

@umut-er
Copy link
Contributor

umut-er commented Jun 12, 2024

Also, there is quite a bit of difference in how pathsBetween and pathsFromTo return nodes. On the same input, pathsFromTo query on cytoscape-graph-algos seems to return much more nodes than pathsBetween. I couldn't quite understand why this happens, it seems kind of counterintuitive to me. I think it might be related to the furtherDistance parameter in the pathsFromTo query but I am not sure. I guess when the highlighting feature gets integrated we can do some testing. I think query highlighting can be integrated before I start working on underlay highlighting mode.

@ugurdogrusoz
Copy link
Contributor Author

@umut-er I wouldn't worry about the discrepancies (which I am not surprised about btw) in the implementations of queries in this context. Just get the highlighting working as requested.

umut-er added a commit that referenced this issue Jun 13, 2024
Highlight query seed genes / paths #389
@umut-er umut-er assigned ugurdogrusoz and unassigned umut-er Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants