Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add instructions into contest announcement dialog #582

Merged
merged 8 commits into from
Apr 6, 2024

Conversation

izharishaksa
Copy link
Contributor

@izharishaksa izharishaksa commented Jan 30, 2024

Screenshot 2024-01-30 at 19 09 06

Resolve #505

@fushar
Copy link
Member

fushar commented Jan 31, 2024

Terima kasih atas kontribusinya, akan saya review dalam beberapa hari ke depan ya 😄

Copy link
Member

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maaf baru balas!

Apakah semua info ini bisa disembunyikan pakai semacam component yang collapsible (https://blueprintjs.com/docs/#core/components/collapse)? Supaya tidak terlalu memenuhi dialog utama-nya.

@izharishaksa
Copy link
Contributor Author

Maaf, kelewatan. Sudah di update.

Copy link
Member

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terima kasih, idenya sudah solid! Mungkin saya akan memperbaiki kalimat dll dengan commit lain.

@fushar
Copy link
Member

fushar commented Apr 6, 2024

Wah, ternyata ada error lint... boleh tolong diperbaiki? :')

@izharishaksa
Copy link
Contributor Author

Done @fushar 😁

@fushar fushar merged commit cd60f5f into ia-toki:master Apr 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show / document how to show image in contest announcements
2 participants