Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature for each bit-width #101

Closed
wants to merge 1 commit into from
Closed

Add a feature for each bit-width #101

wants to merge 1 commit into from

Conversation

ia0
Copy link
Owner

@ia0 ia0 commented Mar 23, 2024

This is a breaking change for those who use default-features = false. The fix is to add back the all feature.

Fixes #97

@ia0
Copy link
Owner Author

ia0 commented Mar 23, 2024

Maybe this should be a major change, in which case it will be possible to also ship the following breaking changes from #72 before releasing:

  • Making the bases static instead of const.
  • Making the Encoding definition private.
  • Bumping MSRV.
  • If there's time, provide &mut [MaybeUninit<u8>] versions.

@ia0
Copy link
Owner Author

ia0 commented Mar 24, 2024

I think it should be a major change. Let's try to see what it would take to expose the polymorphic functions. Maybe the types can be hidden with type aliases:

pub type Base64 = Encoding<Msb, Bit6, Pad, NoWrap>;

@ia0
Copy link
Owner Author

ia0 commented Mar 29, 2024

Closing this in favor of using dyn traits.

@ia0 ia0 closed this Mar 29, 2024
@ia0 ia0 deleted the features branch March 29, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding::encode_mut is very code-size heavy
1 participant