Skip to content

Commit

Permalink
added node 23 to test matrix
Browse files Browse the repository at this point in the history
  • Loading branch information
bumblehead committed Oct 18, 2024
1 parent a57eb3a commit 06ae90a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [18.x, 20.x, 22.x, 23.x]
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# changelog

* 2.6.9 _Oct.18.2024_
* [added node v23 to test matrix](https://github.com/iambumblehead/esmock/pull/316)
* [resolve v23-related error](https://github.com/iambumblehead/esmock/pull/316) when `module.exports` is exported
* 2.6.8 _Oct.17.2024_
* [added pnpm unit-test,](https://github.com/iambumblehead/esmock/pull/315) thanks @darcyrush
* [resolve issue for pnpm](https://github.com/iambumblehead/esmock/pull/315) by escaping '+' char in regexp
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
},
"devDependencies": {
"c8": "^10.1.2",
"eslint": "^9.5.0",
"eslint": "^9.13.0",
"eslint-plugin-markdown": "^5.0.0",
"typescript-eslint": "^8.0.0-alpha.30",
"@typescript-eslint/parser": "^8.0.0-alpha.30",
Expand Down
2 changes: 1 addition & 1 deletion src/esmockModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const isJSONExtnRe = /\.json$/i

// https://github.com/iambumblehead/esmock/issues/284
// older applications may export names that are reserved in newer runtimes
const reservedKeywordsFoundInWild = /(^|,)static($|,)/g
const reservedKeywordsFoundInWild = /(^|,)(static|module\.exports)($|,)/g

// assigning the object to its own prototypal inheritor can error, eg
// 'Cannot assign to read only property \'F_OK\' of object \'#<Object>\''
Expand Down

0 comments on commit 06ae90a

Please sign in to comment.