Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Post-body class selector and exclude .no-fancybox class #9

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

zxy19
Copy link
Contributor

@zxy19 zxy19 commented Aug 27, 2024

Add .Post-body class to image selector to avoid breaking other extension that adds images out of the post.
Add exclude class .no-fancybox to allow developer make their extension compatible with this one.

I found that this extension is breaking my extension user-decoration which will insert other img element without .Avatar class to user's avatar element. And These element were mistakely warped by fancybox.

I suppose that there's no need to select image in the whole .PostStream-item but only the .Post-body element which contains all the content of the post.

By the way, it's not so easy for developer to fix the compability with this extension so I add :not(.no-fancybox) so that developers can easily avoid their element to be warped.

…ion that adds images out of the post.

Add exclude class .no-fancybox to allow developer make their extension compatible with this one.
Copy link

height bot commented Aug 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@iamdarkle iamdarkle merged commit 9ab9359 into iamdarkle:main Sep 2, 2024
2 of 3 checks passed
@iamdarkle
Copy link
Owner

Sorry I missed the notification. Thanks, appreciate the effort! Tagged under v1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants