fix: update Duration plugin to support no-argument (#1400)

iamkun · Mar 8, 2021 · 8d9a5ae · 8d9a5ae
1 parent 319f616
commit 8d9a5ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/plugin/duration/index.js b/src/plugin/duration/index.js
@@ -61,6 +61,10 @@ class Duration {
   constructor(input, unit, locale) {
     this.$d = {}
     this.$l = locale
+    if (input === undefined) {
+      this.$ms = 0
+      this.parseFromMilliseconds()
+    }
     if (unit) {
       return wrapper(input * unitToMS[prettyUnit(unit)], this)
     }

diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js
@@ -17,6 +17,10 @@ afterEach(() => {
 })
 
 describe('Creating', () => {
+  it('no argument', () => {
+    expect(dayjs.duration().toISOString()).toBe('P0D')
+    expect(dayjs.duration().asMilliseconds()).toBe(0)
+  })
   it('milliseconds', () => {
     expect(dayjs.duration(1, 'ms').toISOString()).toBe('PT0.001S')
     expect(dayjs.duration(100).toISOString()).toBe('PT0.1S')