fix: support dayjs.add(Duration), dayjs.subtract(Duration) (#1099)

iamkun · Oct 2, 2020 · b1a0294 · b1a0294
1 parent 16937d1
commit b1a0294
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/plugin/duration/index.js b/src/plugin/duration/index.js
@@ -177,4 +177,13 @@ export default (option, Dayjs, dayjs) => {
     return wrapper(input, { $l }, unit)
   }
   dayjs.isDuration = isDuration
+
+  const oldAdd = Dayjs.prototype.add
+  Dayjs.prototype.add = function (addition, units) {
+    if (isDuration(addition)) {
+      addition = addition.asMilliseconds()
+      units = 'ms'
+    }
+    return oldAdd.bind(this)(addition, units)
+  }
 }
diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js
@@ -139,6 +139,12 @@ describe('Add', () => {
   expect(a.add({ days: 5 }).days()).toBe(6)
 })
 
+describe('Add duration', () => {
+  const a = dayjs('2020-10-01')
+  const days = dayjs.duration(2, 'days')
+  expect(a.add(days).format('YYYY-MM-DD')).toBe('2020-10-03')
+})
+
 describe('Subtract', () => {
   const a = dayjs.duration(3, 'days')
   const b = dayjs.duration(2, 'days')