Export function declarations from LocaleData Plugin #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 174 +2
Lines 1557 1619 +62
Branches 331 356 +25
=========================================
+ Hits 1557 1619 +62
Continue to review full report at Codecov.
|
iamkun
reviewed
Oct 6, 2020
types/plugin/localeData.d.ts
Outdated
| @@ -6,5 +6,14 @@ export = plugin | |||
| declare module 'dayjs' { | |||
| interface Dayjs { | |||
| localeData(): any | |||
There was a problem hiding this comment.
You mean under interface Dayjs?
If so, I think the exported functions should not sit under the interface since those functions are not instance methods of Dayjs.
Instead, those functions are like static, not binding to a class.
There was a problem hiding this comment.
How can typescript knows that weekdaysMin is available on dayjs like this dayjs.weekdaysMin()
There was a problem hiding this comment.
because those functions are exported from module 'dayjs', which has nothing to do with interface Dayjs.
just like MinMax plugin
There was a problem hiding this comment.
True, should we take dayjs().localeData().weekdays() into consideration as well?
There was a problem hiding this comment.
right. I've added localeData types to both dayjs and Dayjs instances.
Now (dayjs or dayjs()).localeData() both have types.
|
Looks cool. Two minor suggestions:
Ref: https://github.com/iamkun/dayjs/blob/dev/src/plugin/localeData/index.js#L21 |
iamkun
pushed a commit
that referenced
this pull request
Oct 23, 2020
## [1.9.4](v1.9.3...v1.9.4) (2020-10-23) ### Bug Fixes * Add descriptions to types ([#1148](#1148)) ([9a407a1](9a407a1)) * add devHelper plugin ([#1163](#1163)) ([de49dc8](de49dc8)) * Fix Hungarian (hu) locale ([#1112](#1112)) ([ab13754](ab13754)) * fix minMax plugin parsing empty array bug ([#1062](#1062)) ([368108b](368108b)) * update adding/subtracting Duration from Dayjs object ([#1156](#1156)) ([f861aca](f861aca)) * update en-NZ locale to use proper ordinal formatting function ([#1143](#1143)) ([fcdbc58](fcdbc58)) * update localeData plugin type ([#1116](#1116)) ([ee5a4ec](ee5a4ec)) * update timezone plugin to support custom parse format ([#1160](#1160)) ([48cbf31](48cbf31)), closes [#1159](#1159) * update timezone plugin to support keepLocalTime ([#1161](#1161)) ([1d429e5](1d429e5)), closes [#1149](#1149)
|
🎉 This PR is included in version 1.9.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.9.4](iamkun/dayjs@v1.9.3...v1.9.4) (2020-10-23) ### Bug Fixes * Add descriptions to types ([#1148](iamkun/dayjs#1148)) ([9a407a1](iamkun/dayjs@9a407a1)) * add devHelper plugin ([#1163](iamkun/dayjs#1163)) ([de49dc8](iamkun/dayjs@de49dc8)) * Fix Hungarian (hu) locale ([#1112](iamkun/dayjs#1112)) ([ab13754](iamkun/dayjs@ab13754)) * fix minMax plugin parsing empty array bug ([#1062](iamkun/dayjs#1062)) ([368108b](iamkun/dayjs@368108b)) * update adding/subtracting Duration from Dayjs object ([#1156](iamkun/dayjs#1156)) ([f861aca](iamkun/dayjs@f861aca)) * update en-NZ locale to use proper ordinal formatting function ([#1143](iamkun/dayjs#1143)) ([fcdbc58](iamkun/dayjs@fcdbc58)) * update localeData plugin type ([#1116](iamkun/dayjs#1116)) ([ee5a4ec](iamkun/dayjs@ee5a4ec)) * update timezone plugin to support custom parse format ([#1160](iamkun/dayjs#1160)) ([48cbf31](iamkun/dayjs@48cbf31)), closes [#1159](iamkun/dayjs#1159) * update timezone plugin to support keepLocalTime ([#1161](iamkun/dayjs#1161)) ([1d429e5](iamkun/dayjs@1d429e5)), closes [#1149](iamkun/dayjs#1149)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.9.4](iamkun/dayjs@v1.9.3...v1.9.4) (2020-10-23) ### Bug Fixes * Add descriptions to types ([#1148](iamkun/dayjs#1148)) ([9a407a1](iamkun/dayjs@9a407a1)) * add devHelper plugin ([#1163](iamkun/dayjs#1163)) ([de49dc8](iamkun/dayjs@de49dc8)) * Fix Hungarian (hu) locale ([#1112](iamkun/dayjs#1112)) ([ab13754](iamkun/dayjs@ab13754)) * fix minMax plugin parsing empty array bug ([#1062](iamkun/dayjs#1062)) ([368108b](iamkun/dayjs@368108b)) * update adding/subtracting Duration from Dayjs object ([#1156](iamkun/dayjs#1156)) ([f861aca](iamkun/dayjs@f861aca)) * update en-NZ locale to use proper ordinal formatting function ([#1143](iamkun/dayjs#1143)) ([fcdbc58](iamkun/dayjs@fcdbc58)) * update localeData plugin type ([#1116](iamkun/dayjs#1116)) ([ee5a4ec](iamkun/dayjs@ee5a4ec)) * update timezone plugin to support custom parse format ([#1160](iamkun/dayjs#1160)) ([48cbf31](iamkun/dayjs@48cbf31)), closes [#1159](iamkun/dayjs#1159) * update timezone plugin to support keepLocalTime ([#1161](iamkun/dayjs#1161)) ([1d429e5](iamkun/dayjs@1d429e5)), closes [#1149](iamkun/dayjs#1149)
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.9.4](iamkun/dayjs@v1.9.3...v1.9.4) (2020-10-23) ### Bug Fixes * Add descriptions to types ([#1148](iamkun/dayjs#1148)) ([9a407a1](iamkun/dayjs@9a407a1)) * add devHelper plugin ([#1163](iamkun/dayjs#1163)) ([de49dc8](iamkun/dayjs@de49dc8)) * Fix Hungarian (hu) locale ([#1112](iamkun/dayjs#1112)) ([ab13754](iamkun/dayjs@ab13754)) * fix minMax plugin parsing empty array bug ([#1062](iamkun/dayjs#1062)) ([368108b](iamkun/dayjs@368108b)) * update adding/subtracting Duration from Dayjs object ([#1156](iamkun/dayjs#1156)) ([f861aca](iamkun/dayjs@f861aca)) * update en-NZ locale to use proper ordinal formatting function ([#1143](iamkun/dayjs#1143)) ([fcdbc58](iamkun/dayjs@fcdbc58)) * update localeData plugin type ([#1116](iamkun/dayjs#1116)) ([ee5a4ec](iamkun/dayjs@ee5a4ec)) * update timezone plugin to support custom parse format ([#1160](iamkun/dayjs#1160)) ([48cbf31](iamkun/dayjs@48cbf31)), closes [#1159](iamkun/dayjs#1159) * update timezone plugin to support keepLocalTime ([#1161](iamkun/dayjs#1161)) ([1d429e5](iamkun/dayjs@1d429e5)), closes [#1149](iamkun/dayjs#1149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.