Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert removed type definitions #1361

Merged
merged 3 commits into from
Feb 4, 2021
Merged

fix: revert removed type definitions #1361

merged 3 commits into from
Feb 4, 2021

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Jan 27, 2021 •
edited
Loading

See #1360

@zardoy
Copy link
Contributor Author

zardoy commented Jan 31, 2021

@iamkun Please could you merge this to revert the breaking change?
As you can remember I removed publicy available type definitions. This PR restores them.

iamkun
iamkun reviewed Jan 31, 2021
View reviewed changes
types/plugin/duration.d.ts Outdated Show resolved Hide resolved
@zardoy
Copy link
Contributor Author

zardoy commented Feb 3, 2021

Hey, @iamkun do you have any updates on that? :)

@iamkun
Copy link
Owner

iamkun commented Feb 4, 2021

THX

@iamkun iamkun merged commit b817098 into iamkun:dev Feb 4, 2021
@iamkun
Copy link
Owner

iamkun commented May 26, 2021

🎉 This PR is included in version 1.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zardoy @iamkun