පරිවර්තන නිවරදි කිරීම #1475

Aikatsui · 2021-04-27T02:18:56Z

This fix incorrect localization for sinhalese/sinhala language (sri lanka). Below describe using examples

e.g. January
current: ජනවාරි (janavaari)
update: දුරුතු (duruthu)

e.g. August
current: අගෝස්තු (agoosthu)
update: නිකිණි (nikini)

I saw @aadityataparia @iamkun have updated si.js then do you remember the source of that resources? if then it will helpful for me to follow and re-correct.

codecov · 2021-04-27T02:20:38Z

Codecov Report

Merging #1475 (80ae50a) into dev (0fdac93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1475   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         176      176           
  Lines        1770     1770           
  Branches      411      411           
=======================================
  Hits         1769     1769           
  Misses          1        1

Impacted Files	Coverage Δ
src/locale/si.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fdac93...80ae50a. Read the comment docs.

iamkun · 2021-04-27T12:54:40Z

the source file should be this https://github.com/moment/moment/blob/develop/locale/si.js

Aikatsui · 2021-04-27T22:15:11Z

the source file should be this https://github.com/moment/moment/blob/develop/locale/si.js

謝謝! I already found it and added PR. you can merge this changes meanwhile however let me know if i need to provide more details about that

iamkun · 2021-05-26T07:42:13Z

I'm not sure if we should keep the same with momentjs or not?

Aikatsui · 2021-05-27T00:41:08Z

I'm not sure if we should keep the same with momentjs or not?

Same PR for that repository moment/moment#5877
There're many localization related fixes PRs on momentjs moment/pulls but it seems take long time for review them

Project Status
Moment.js is a legacy project, now in maintenance mode. In most cases, you should choose a different library.

https://momentjs.com/docs/#/-project-status/

We will not be making any major changes (no version 3).

We may choose to not fix bugs or behavioral quirks, especially if they are long-standing known issues.

May be, someone from dayjs able to join to momentjs for review PRs for example. I'm not sure if that necessary or convenient otherwise you may able to take a look at important PRs randomly and apply them to dayjs.

iamkun · 2021-06-28T06:56:08Z

Thanks, I'll mark this PR for more code review by native speakers before it gets merged.

dinithija · 2021-06-29T18:32:36Z

@iamkun @Aikatsui notified me; I'm sinhalese language native speaker.

About the PR - it's correct. people're using them since ancient times and now, also for astrology, horoscopes etc.
- https://si.wikipedia.org/wiki/චන්ද්‍ර_මාස
About old names - those're westernized/adopted words for unknown purposes some years ago. eg: follow western style.
(above @Aikatsui has provided examples; eg: january - ජනවාරි (janavaari)

itsnotsaved · 2021-07-21T15:57:38Z

Thanks, I'll mark this PR for more code review by native speakers before it gets merged.

can you merge this? see another resource with pronunciation https://masteranylanguage.com/c/b/o9ly878fJ/98-Sinhala-MonthsOfYear-Learn-Step-By-Step (first three rows contain 12 months loan names. you can easily recognize them because it has pronunciation and then correct 12 months names)

iamkun · 2021-07-27T07:55:05Z

sure, LGTM

## [1.10.7](v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](#1614)) ([3393f2a](3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](#1627)) ([b5a1391](b5a1391)) * add format object type to type file ([#1572](#1572)) ([5a79cc6](5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](#1611)) ([252585b](252585b)) * narrow type for `add` and `subtract` ([#1576](#1576)) ([1686962](1686962)) * update customParseFormat plugin strict x X parsing ([#1571](#1571)) ([08adda5](08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](#1609)) ([255dc54](255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](#1608)) ([7a8467c](7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](#1566)) ([755fc8b](755fc8b)) * update Sinhalese [si] locale month name ([#1475](#1475)) ([63de2a8](63de2a8)) * update utcOffset plugin type file ([#1604](#1604)) ([f68e4b1](f68e4b1))

iamkun · 2021-09-10T09:34:50Z

🎉 This PR is included in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))

## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))

පරිවර්තන නිවරදි කිරීම

80ae50a

iamkun added the Need Review label Jun 28, 2021

iamkun merged commit 63de2a8 into iamkun:dev Jul 27, 2021

iamkun added the released label Sep 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

පරිවර්තන නිවරදි කිරීම #1475

පරිවර්තන නිවරදි කිරීම #1475

Aikatsui commented Apr 27, 2021

codecov bot commented Apr 27, 2021 •

edited

Loading

iamkun commented Apr 27, 2021

Aikatsui commented Apr 27, 2021

iamkun commented May 26, 2021

Aikatsui commented May 27, 2021

iamkun commented Jun 28, 2021

dinithija commented Jun 29, 2021

itsnotsaved commented Jul 21, 2021 •

edited

Loading

iamkun commented Jul 27, 2021

iamkun commented Sep 10, 2021

පරිවර්තන නිවරදි කිරීම #1475

පරිවර්තන නිවරදි කිරීම #1475

Conversation

Aikatsui commented Apr 27, 2021

codecov bot commented Apr 27, 2021 • edited Loading

Codecov Report

iamkun commented Apr 27, 2021

Aikatsui commented Apr 27, 2021

iamkun commented May 26, 2021

Aikatsui commented May 27, 2021

iamkun commented Jun 28, 2021

dinithija commented Jun 29, 2021

itsnotsaved commented Jul 21, 2021 • edited Loading

iamkun commented Jul 27, 2021

iamkun commented Sep 10, 2021

codecov bot commented Apr 27, 2021 •

edited

Loading

itsnotsaved commented Jul 21, 2021 •

edited

Loading