Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esm duration typings. #1589

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix esm duration typings. #1589

merged 1 commit into from
Aug 4, 2021

Conversation

mshima
Copy link
Contributor

@mshima mshima commented Jul 22, 2021

Fixes esm duration typing reference.

Contains the required part of #1544.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1589 (c292f7d) into dev (c5688f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       177    +1     
  Lines         1980      1989    +9     
  Branches       502       505    +3     
=========================================
+ Hits          1980      1989    +9     
Impacted Files Coverage Δ
src/plugin/advancedFormat/index.js 100.00% <0.00%> (ø)
src/plugin/customParseFormat/index.js 100.00% <0.00%> (ø)
src/locale/sv-fi.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5688f3...c292f7d. Read the comment docs.

@mshima
Copy link
Contributor Author

mshima commented Aug 4, 2021

@iamkun would be nice have this merged before next release.
This is preventing us from switching to esm.

@iamkun
Copy link
Owner

iamkun commented Aug 4, 2021

Thanks

@iamkun iamkun merged commit e2feb6b into iamkun:dev Aug 4, 2021
@mshima mshima deleted the esm_duration branch August 4, 2021 09:52
@iamkun
Copy link
Owner

iamkun commented Sep 10, 2021

🎉 This PR is included in version 1.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants