Fixed #587: Replaced add method for setMonth method #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #589 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 983 983
Branches 140 140
===================================
Hits 983 983
Continue to review full report at Codecov.
|
iamkun
reviewed
May 7, 2019
| @@ -4,7 +4,7 @@ export default (o, c) => { | |||
| const proto = c.prototype | |||
| proto.quarter = function (quarter) { | |||
| if (!this.$utils().u(quarter)) { | |||
| return this.add((quarter - 1) * 3, M) | |||
| return this.month(((quarter - 1) * 3) + (this.month() % 3), M) | |||
There was a problem hiding this comment.
Just noticed that you already have a fix here. But the 2nd argument M seems unnecessary.
|
#591 close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
setQuarterlogic had a wrong method call.Fix it, and added some test to reproduce the original issue