Add optional properties to DA locale #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamkun
reviewed
Jul 9, 2019
| months: 'januar_februar_marts_april_maj_juni_juli_august_september_oktober_november_december'.split('_'), | ||
| monthsShort: 'jan._feb._mar._apr._maj_juni_juli_aug._sept._okt._nov._dec.'.split('_'), |
There was a problem hiding this comment.
thanks, how about removing all the ending dot to keep the same with https://github.com/moment/moment/blob/develop/locale/da.js ?
There was a problem hiding this comment.
Thanks for the comment!
I would argue that the dots are part of the way short versions of months are to be displayed in Danish. Similar to the way it's handled in Norwegian (Bokmål):
https://github.com/iamkun/dayjs/blob/dev/src/locale/nb.js
You can also see the format used in the Wikipedia article about date formatting in Denmark:
https://en.m.wikipedia.org/wiki/Date_and_time_notation_in_Denmark
There was a problem hiding this comment.
According to Wikipedia, seems not dot as well?:
lørdag, den 1. januar 2000
tirsdag, den 25. juni 2019
lørdag 1. januar 2000
tirsdag 25. juni 2019
There was a problem hiding this comment.
That's the examples with full months :) I only changed the short versions that use abbreviations. From the Wikipedia article:
- jan. 2000 (versus 1. januar 2000)
iamkun
pushed a commit
that referenced
this pull request
Aug 27, 2019
## [1.8.16](v1.8.15...v1.8.16) (2019-08-27) ### Bug Fixes * Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](a385d5c)) * Handle locale in WeekOfYear plugin ([#658](#658)) ([0e45b0a](0e45b0a)) * LocaleData plugin returns all months and weekdays data when pas no argument ([#645](#645)) ([95e70b4](95e70b4)) * Return null in toJSON if not valid ([#633](#633)) ([19affc8](19affc8)) * Update Danish (da) locale ([#626](#626)) ([ac2ec77](ac2ec77)) * Update Korean locale meridiem ([#642](#642)) ([b457146](b457146)) * update Occitan locale Catalan locale ([#630](#630)) ([fef135e](fef135e)) * update pt-br locale ([#628](#628)) ([ccf596d](ccf596d)) * Update weekdaysShort to some locale files ([#643](#643)) ([cc1f15f](cc1f15f))
|
🎉 This PR is included in version 1.8.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27) ### Bug Fixes * Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c)) * Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a)) * LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4)) * Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8)) * Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77)) * Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146)) * update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e)) * update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d)) * Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27) ### Bug Fixes * Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c)) * Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a)) * LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4)) * Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8)) * Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77)) * Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146)) * update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e)) * update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d)) * Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27) ### Bug Fixes * Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c)) * Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a)) * LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4)) * Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8)) * Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77)) * Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146)) * update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e)) * update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d)) * Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional properties
weekdaysShort,weekdaysMinandmonthsShortto the Danish locale.All changes have been crosschecked using a Danish dictionary:
https://ordnet.dk/ddo/ordbog