Italian locale relative time translation fix #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [1.8.17](iamkun/dayjs@v1.8.16...v1.8.17) (2019-11-06) ### Bug Fixes * Fix set utcOffset in utc mode ([d148115](iamkun@d148115)) * Update advancedFormat plugin to support w ww wo week tokens … ([iamkun#678](iamkun#678)) ([26cfa63](iamkun@26cfa63)), closes [iamkun#676](iamkun#676) * Update ka locale weekdays ([f8ca3d4](iamkun@f8ca3d4)) * Update nb locale ([iamkun#679](iamkun#679)) ([1063b0e](iamkun@1063b0e)) * Update Polish locale (pl)([iamkun#713](iamkun#713)) ([30d2f02](iamkun@30d2f02)) * Update Ukrainian locale (uk) ([iamkun#710](iamkun#710)) ([360161c](iamkun@360161c)) * UTC plugin set utcOffset value ([iamkun#668](iamkun#668)) ([8877883](iamkun@8877883))
"3 hours ago" Currently it is translated to "da 3 ore". It is grammatically correct, but it has a different meaning (it means that something has been occurring for 3 hours, not that occurred 3 hours ago). The correct translation would be "3 ore fa". MomentJS translates in the same way.
Codecov Report
@@ Coverage Diff @@
## dev #727 +/- ##
===================================
Coverage 100% 100%
===================================
Files 154 154
Lines 1017 1017
Branches 157 157
===================================
Hits 1017 1017
Continue to review full report at Codecov.
|
|
Looks good! Can you cherry-pick and submit your commit only, please? |
|
Hi @iamkun! Can you please suggest me how to do it? I have never done it before. Thanks! |
|
@guidolodetti You can try |
iamkun
pushed a commit
that referenced
this pull request
Dec 18, 2019
## [1.8.18](v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](#716)) ([cde5d0b](cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](78ec173)) * Update Italian locale (it) ([#727](#727)) ([5b53e98](5b53e98)) * Update locale (fa) ([#733](#733)) ([9ad2e47](9ad2e47)) * Update locale (zh-cn) ([#706](#706)) ([e31e544](e31e544)) * Update locale (zh-cn) meridiem ([#735](#735)) ([15d1b81](15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](#734)) ([aa0f210](aa0f210)), closes [#680](#680) * Update Mongolian (mn) locale relativeTime ([#753](#753)) ([6d51435](6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](#745)) ([49670d5](49670d5)), closes [#743](#743)
|
🎉 This PR is included in version 1.8.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173)) * Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98)) * Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47)) * Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544)) * Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680) * Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173)) * Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98)) * Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47)) * Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544)) * Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680) * Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.8.18](iamkun/dayjs@v1.8.17...v1.8.18) (2019-12-18) ### Bug Fixes * Add missing locale type definition ([#716](iamkun/dayjs#716)) ([cde5d0b](iamkun/dayjs@cde5d0b)) * Fix .locale() handel unsupported locale ([78ec173](iamkun/dayjs@78ec173)) * Update Italian locale (it) ([#727](iamkun/dayjs#727)) ([5b53e98](iamkun/dayjs@5b53e98)) * Update locale (fa) ([#733](iamkun/dayjs#733)) ([9ad2e47](iamkun/dayjs@9ad2e47)) * Update locale (zh-cn) ([#706](iamkun/dayjs#706)) ([e31e544](iamkun/dayjs@e31e544)) * Update locale (zh-cn) meridiem ([#735](iamkun/dayjs#735)) ([15d1b81](iamkun/dayjs@15d1b81)) * Update LocaleData plugin to support dayjs().longDateFormat() ([#734](iamkun/dayjs#734)) ([aa0f210](iamkun/dayjs@aa0f210)), closes [#680](iamkun/dayjs#680) * Update Mongolian (mn) locale relativeTime ([#753](iamkun/dayjs#753)) ([6d51435](iamkun/dayjs@6d51435)) * Update Swedish locale (sv) fix ordinal error ([#745](iamkun/dayjs#745)) ([49670d5](iamkun/dayjs@49670d5)), closes [#743](iamkun/dayjs#743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"3 hours ago"
Currently it is translated to "da 3 ore". It is grammatically correct, but it has a different meaning (it means that something has been occurring for 3 hours, not that occurred 3 hours ago).
The correct translation would be "3 ore fa". MomentJS translates it in the same way.